addressalign-toparrow-leftarrow-leftarrow-right-10x10arrow-rightbackbellblockcalendarcameraccwcheckchevron-downchevron-leftchevron-rightchevron-small-downchevron-small-leftchevron-small-rightchevron-small-upchevron-upcircle-with-checkcircle-with-crosscircle-with-pluscontroller-playcredit-cardcrossdots-three-verticaleditemptyheartexporteye-with-lineeyefacebookfolderfullheartglobe--smallglobegmailgooglegroupshelp-with-circleimageimagesinstagramFill 1languagelaunch-new-window--smalllight-bulblightning-boltlinklocation-pinlockm-swarmSearchmailmediummessagesminusmobilemoremuplabelShape 3 + Rectangle 1ShapeoutlookpersonJoin Group on CardStartprice-ribbonprintShapeShapeShapeShapeImported LayersImported LayersImported Layersshieldstar-shapestartickettrashtriangle-downtriangle-uptwitteruserwarningyahooyoutube

Re: [softwaredev-113] code review?

From: Andy L.
Sent on: Tuesday, December 11, 2012, 4:05 PM

On Dec 11, 2012, at 4:04 PM, Luke Pacholski <[address removed]> wrote:

One thing worth mentioning - I've found code reviews are only useful if the developer is engaged and is looking for constructive criticism. I've been in a few where the developer clearly doesn't care and basically shrugs off any comments/issues.

That's why code reviews have to leave with actionable items.  It needs to be made clear "This must be fixed" vs. "This is just a comment that you may or may not care about."

xoa


--
Andy Lester => [address removed] => www.petdance.com => AIM:petdance

Madison, WI

Founded Aug 1, 2008

Member Dues

$30.00/year

60 day free trial

This money helps us:
  • Cover Meetup costs
  • Have a reserve fund
  • Improve Meetups
+ more

Organizer:

Ryan
Contact

This Meetup is community funded

$30.00/year

Member dues are used to:
  • Cover Meetup costs
  • Have a reserve fund
  • Improve Meetups
Join us Close

60 day free trial

No credit card required

After the trial you must pay dues to be a member of this Meetup.

Cancel dues at any time.

Dues are billed each year.

People in this
group are also in: