Re: [ljc] Performance Tuning of a large Method
| From: | Ben E. |
| Sent on: | Tuesday, October 23, 2012, 2:42 PM |
Hi Craig,
First things first - grab javap and decompile the method.
That way you can see how many bytecodes it's actually turned into.
Next, you should check that it's actually compiling, so use the PrintCompilation flag in UAT (see Stephen's blog article here: http://blog.joda.org/2011/08/printcompilation-jvm-flag.html if you need help driving PrintCompilation) & check that the method is actually compiling.
Next, check that the 185-line monster isn't calling any other methods that may be long-running (e.g. database calls). In short, you need to check that the problem really is where you think it is. You need to know how much of that 40 seconds is intrinsic to the 185-liner. The problem may not be where you think it is.
Next, look at the unit tests. If you don't have any unit tests, you need to fix that issue.
That should keep you going for a bit.
Ben
First things first - grab javap and decompile the method.
That way you can see how many bytecodes it's actually turned into.
Next, you should check that it's actually compiling, so use the PrintCompilation flag in UAT (see Stephen's blog article here: http://blog.joda.org/2011/08/printcompilation-jvm-flag.html if you need help driving PrintCompilation) & check that the method is actually compiling.
Next, check that the 185-line monster isn't calling any other methods that may be long-running (e.g. database calls). In short, you need to check that the problem really is where you think it is. You need to know how much of that 40 seconds is intrinsic to the 185-liner. The problem may not be where you think it is.
Next, look at the unit tests. If you don't have any unit tests, you need to fix that issue.
That should keep you going for a bit.
Ben
On Tue, Oct 23, 2012 at 2:34 PM, Craig Silk <[address removed]> wrote:
Good morning,I'm working on a rather high trafficked ecommerce platform at the moment where I seem to having some performance issues.I've hooked visualJVM up to the application to find that one particular method is taking over 40 seconds to complete when load is high. Looking at the method, I see it's a 185 line copy and paste job from a legacy codebase that has some rather verbose conditionals and lots of interactions with Collections.I know I haven't given enough information for anyone to really help me but I'm curious as to how you would generally go about dealing with a 185 line, synchronised java method that was lifted out of a legacy codebase. Where am I supposed to begin when refactoring this mess?Craig
--
Please Note: If you hit "REPLY", your message will be sent to everyone on this mailing list ([address removed])
This message was sent by Craig Silk ([address removed]) from LJC - London Java Community.
To learn more about Craig Silk, visit his/her member profile
Set my mailing list to email me As they are sent | In one daily email | Don't send me mailing list messages
Meetup, PO Box 4668 #37895 New York, New York[masked] | [address removed]![]()
People in this
group are also in:
-
K8SUG UK
5,831 K8SUGers
-
Graph Database - United Kingdom
4,332 People
-
London Startup Founder 101
10,785 Aspiring Founders
-
Virtual Java User Group
18,078 vJUGers
-
London Scala Users' Group
3,950 Enthusiasts
-
London Gophers
5,549 Gophers