Code Review Panel

It's easy to code in a bubble, but how often do you get to see a group of Node experts dive into a piece of code together, tearing it apart and coming out with a finely-tuned instrument of asynchronous magic?

We are asking for community contributions of code: either something you wrote or something you use, anonymously if you like. Also, we are looking for volunteers for the panel! Please contact Aidan if interested in either: http://www.meetup.com/nodejs/members/8818215/

 

Panel

Haris Amin is a full-stack developer at DailyBurn.  He's the creator of CyborgVision, and in his free time likes to dominate hackathons.

Aidan Feldman (moderator), developer at Artsy by day, dancer by night. api.afeld.me

Sam Liu was trained as a physicist and used to be a college professor. He works for a digital agency and enjoys personal coding on his iPhone. twitter.com/ontouchstart

Leon Stankowski is a 30+ year veteran software developer, CTO and CEO.  Started professionally programming in high school developing a forerunning to the Internet for Time Life and since then developed compilers, interpreters, high performance trading systems, online gaming systems and charitable giving companies to name a few areas of interest.  Recently I head technology for Rewind.me, a TechStars supported company, and chose Node and Mongo to create our high performance and highly scalable system.

Matt Walters is co-organizer of the NYC Node.js meetup. He's been an engineer, consultant, and CTO. In Node, he's built everything from sites to distributed services to a sensor-rich, high-tech, touch screen treadmill.

Join or login to comment.

  • Matt W.

    Hi everybody. In response to last night's successful code review, we'd like to set ourselves up for even more bashing, smashing, and rebuilding at the next meetup. I've started a new discussion here: http://www.meetup.com/nodejs/messages/boards/thread/34555582#[masked] where you guys can all make submissions to our next set of code reviews. If you have some code that you want help with, or have a piece you think is already good but the community can make better, submit it and come show your code at the podium!

    May 16, 2013

    • Vietnhi P.

      Yay, let the blood flow and the pointers get picked up :)

      May 16, 2013

  • eugene r.

    It'll be a big loss if this is not video taped.

    May 15, 2013

    • eugene r.

      it's not the starting point or the final product that is important. Sometimes you learn most from the process of getting there.

      May 16, 2013

    • Vietnhi P.

      Funny, I never tried saying that to any of my bosses ... :)

      May 16, 2013

  • Sergey S.

    The code review panel was great. Refactoring as a group was fun. Here is the jsPerf for module vs prototypal http://jsperf.com/prototypal-performance/12. Wondering if you can review code with Enterprise Design Patterns used in nodejs next time?

    May 16, 2013

    • Matt W.

      Fowler has a book called Enterprise Design Patterns. You can see most of them here: http://martinfowler.c...­

      Most design pattern books are in C# or Java, but most patterns apply to Javascript as well (excluding things for interfaces, abstract classes and such). Adapter, Factory, Repository, Facade, Command, Singleton all work just as well in JS as do a bunch of others.

      May 16, 2013

    • Sergey S.

      Thanks Matt! I have followed these patterns in C# and getting acquainted using them in javascript.

      May 16, 2013

  • Jason C.

    Just a couple followups to points made or questions asked last night:

    On variable hoisting:
    - https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Statements/var#var_hoisting
    - http://www.2ality.com/2013/05/quirk-variable-scope.html
    (A deeper dive into these concepts):
    - http://www.2ality.com/2011/02/javascript-variable-scoping-and-its.html
    - http://www.2ality.com/2012/11/var-statement-rules.html

    On caching .length for a for loop:
    - It was considered an optimization to use a cached value of the array length (e.g. for ( var i = 0, len = array.length; i < len; i++) {...}) but whether or not javascript engines have internalized the caching operation of array lengths, current perf testing shows that this optimization has been mitigated if not reversed.
    - A point for caching comes from a slightly contrived potential bug when using the non-cached value: if the array was to be modified inside the loop it could create an infinite loop when using .length.

    1 · May 16, 2013

  • Joe G.

    This was very useful. The refactoring and discussion of best practices with very helpful. For our next meeting, I would love to hear a discussion on asynchronous programming and managing callback hell. Thanks again.

    2 · May 16, 2013

  • Sergey S.

    I'm interested in other approaches.

    May 16, 2013

  • Sergey S.

    Sure. I'm interested in what design patterns implementations and tools that people are using from the api to data access level (active record, repositories...). In the last panel people were using mongoose for data access and that

    May 16, 2013

  • A former member
    A former member

    A fun learning experience

    May 16, 2013

  • John T.

    Great idea to have group refactor code

    May 15, 2013

  • Vietnhi P.

    I love code beat downs :)

    May 15, 2013

  • Manny

    The code review panel was great. Lots of useful information for javascript/nodejs coders.

    1 · May 15, 2013

  • Tapan S.

    This was good. This should be a bi-weekly activity

    1 · May 15, 2013

  • Aidan F.

    May 15, 2013

  • Jayson J. P.

    Sorry - got caught up at work.

    May 15, 2013

  • Jamal

    Stuck at work.

    May 15, 2013

  • Ashish G.

    sorry can't make it.

    May 15, 2013

  • David B.

    I decided that I do want to stay in my code bubble after all, so will not have the pleasure of co-contemplating code with the Node.js experts here; today at least.

    1 · May 15, 2013

  • Aaron P.

    Late night work hustle. Hopefully there's another in the future.

    May 15, 2013

  • Mark W.

    Sorry, last minute issue.. Can't make it.. Hope someone else can.. Mark

    May 15, 2013

  • Michael D. M.

    Cool opportunity. Thanks.

    May 4, 2013

Our Sponsors

  • Pivotal Labs

    Free office space for monthly meetings

  • JetBrains

    Free licenses raffled once a month @main meetup for Jetbrains IDEs

  • Hakka Labs

    International community of startup software engineers

  • Pearson

    Books to raffle plus a discount on materials

Create a Meetup Group and meet new people

Get started Learn more
Allison

Meetup has allowed me to meet people I wouldn't have met naturally - they're totally different than me.

Allison, started Women's Adventure Travel

Sign up

Meetup members, Log in

By clicking "Sign up" or "Sign up using Facebook", you confirm that you accept our Terms of Service & Privacy Policy