On Wed, Jan 30, 2013 at 12:06 PM, Colin Soho Cobra Vipurs <[address removed]>
Concerning code reviews, I have found they are unpopular among some developers, and can get 'forgotten' fairly quickly, as a thing you can get away with not doing. Pair programming can give similar benefits as code review, at the point of coding, rather than
I've never managed to work anywhere where code reviews actually happen on a regular basis. They come and go, and are always the first thing to be thrown out when time gets a little bit tight. I've often found the other problem with code reviews is that regardless of how they are run, there is always someone in the room who will feel like their work is being singled out.
I just wanted to add an alternative viewpoint to this. In my workplace code-reviews are very bedded in now and it's hard to imagine anyone suggesting removing them, and I don't remember anyone suggesting it when we've faced very tight deadlines. Maybe it's because of our large code-base, but previously it's been very easy to introduce new bugs in the past when fixing other issues. Having the right reviewers on a changelist reduces the chance of this significantly.
I often feel I'm being unfairly criticised when my code is being reviewed, but then I look at other reviews of code by developers I admire and sometimes see just as many defects being raised.
As I say, it may be something peculiar to our codebase. Or maybe we've somehow got the process right.